Ginkgo tests #17
Merged
Ginkgo tests #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
This test revealed that we didn't care if the API client is nil, which caused the controller to crash when trying to list OS images. Signed-off-by: Oz Tiram <oz.tiram@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
===========================================
+ Coverage 20.45% 59.28% +38.83%
===========================================
Files 2 2
Lines 132 140 +8
===========================================
+ Hits 27 83 +56
+ Misses 104 51 -53
- Partials 1 6 +5
Continue to review full report in Codecov by Sentry.
|
TylerGillson
approved these changes
Feb 15, 2024
This was referenced Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ginkgo tests.